JimDanner

Results 20 comments of JimDanner

> @JimDanner : How is your generator (or the upstream project at https://github.com/jsmnbom/definitelytyped-firefox-webext-browser) dealing with Manifest V3? Since there are differences to Manifest V2, I assume your generated type definition...

> I see. The descriptions are piped into Sphinx to build our documentation. It will be difficult to remove them. But why do you need to manually change some? We...

> That is exactly what that reStructuredText notation for inline links does. Nothing has been left out. There _is_ a different notation, which uses placeholders, which has a single underscore...

I think it would be better to put the alternative promise-values in the schemas explicitly. One reason is that formally, the type of an optional parameter `param?: T` is equivalent...

As I don't know why `undefined` was implemented in some returns, I can't tell with certainty. But it seems more reasonable that the return value would be `null`. An`undefined` return...

> Can we establish that an optional return value is equivalent to returning `null`, so these two describe the same thing (and I do not have to change all schema...

Great. Are there any APIs that may return a completely empty promise? Or is that equivalent to `undefined`? For example, the callback that's the last argument to `tabs.create()`: its parameter,...

> The github workflow test files are not supposed to be included in the API update? Are you asking me whether they are supposed to be included, or are you...

@iisaduan Alright, I have deleted the files from the PR.