compose-multiplatform icon indicating copy to clipboard operation
compose-multiplatform copied to clipboard

Package uber JAR with Proguard

Open badmannersteam opened this issue 2 years ago • 5 comments

PR for #4129.

  1. Added support to join JARs to the uber JAR with ProGuard, disabled by default.
  2. All 'release' tasks now really depend on ProGuard, as stated in tutorial.

badmannersteam avatar Jan 17 '24 16:01 badmannersteam

@badmannersteam could you add integration tests for that?

terrakok avatar Jan 19 '24 11:01 terrakok

@terrakok probably yes, but what configuration combinations they should check?

badmannersteam avatar Jan 19 '24 15:01 badmannersteam

I would expect a multi-module project + proguard as uberjar and a regular multi-module project

terrakok avatar Jan 19 '24 16:01 terrakok

Added some tests.

badmannersteam avatar Feb 01 '24 20:02 badmannersteam

@terrakok seems like that all for now.

badmannersteam avatar Feb 16 '24 00:02 badmannersteam

I'll check the tests today and also want to fix the issue on Windows, that was mentioned above (by flattering into the intermediate jar instead of directory).

badmannersteam avatar Mar 12 '24 09:03 badmannersteam

@badmannersteam could you check failed tests and rebase the branch on top of the master?

terrakok avatar Mar 12 '24 11:03 terrakok

@terrakok all done.

badmannersteam avatar Mar 12 '24 19:03 badmannersteam

@igordmn, look at this pls :)

badmannersteam avatar Mar 18 '24 15:03 badmannersteam

@terrakok @igordmn I apologize for being intrusive, but are there any chances that this will be merged before the next release? Just want to know for proper planning.

badmannersteam avatar Apr 05 '24 12:04 badmannersteam

Most probably yes, it will be in the next release (1.6.10).

I plan to review it soon.

igordmn avatar Apr 05 '24 12:04 igordmn