uniswapv3-code

uniswapv3-code copied to clipboard

Change all instances: `PoolParams:mintLiqudity` to `PoolParams:mintLiquidity`

McCoady

balanceOf signature should be restricted to view so it uses a static call rather than a regular call to the contract (avoids potential attacks by malicious contracts who's balanceOf implementation...

McCoady

OoXooOx

jsbi.ts not found

3

I followed the steps and everything went fine. Finally, when I started the ui interface, it showed that the dependency could not be found. ``` $ cd ui && yarn...

ghost

Unable to use the frontend

2

I followed all the steps and the contract parts worked okay after using `anvil --code-size-limit 4857` but on the frontend side after install all dependencies and running `yarn start` I...

stevyhacker

How to set the fee for adding liquidity?

1

How to set the fee for adding liquidity?

phpmac

Checking input amount when burning

1

The input amount must less than the amount that a LP have in a position, it's apparently here's no logic error in the code because `LiquidityMath.addLiquidity(a,b)` will make sure a>b...

TAnNbR

Rounding problem

2

https://github.com/Jeiwan/uniswapv3-code/blob/419fd1dd2aabc0bdbfe326ed34cc641934e49210/test/UniswapV3Pool.t.sol#L643C58-L643C75 Is not it some kind of an issue worth fixing? I think it is intolerable to burn money like that. As far as i get it nobody would be...

m1s5

I added `getLiquidityByAddress` & `getAccumulatedFee` functions to UniswapV3Pool.sol Also added `sqrtPFromDecimal` to the Math.sol library I think these functions are necessary for UniswapV3 Looking forward to feedback from you. If...

NFTknight

Kali-Decoder