react-md-editor icon indicating copy to clipboard operation
react-md-editor copied to clipboard

React 16 support

Open insolite opened this issue 8 years ago • 9 comments

As mentioned in React 15.5 release notes, React.createClass (MDEditor.js#L13) and React.PropTypes (MDEditor.js#L16-L19) are now deprecated. Are there any plans for making further releases with such replacements to make editor support React 16?

insolite avatar Oct 08 '17 10:10 insolite

Yeah total bummer; doesn't seem to work anymore.

daanishnasir avatar Nov 15 '17 17:11 daanishnasir

No, no work in React 16! :(

JodieHag avatar Jan 15 '18 14:01 JodieHag

+1

ttbarnes avatar Jan 23 '18 13:01 ttbarnes

Wait, why is this hard to fix? Isn't is just refactor out React.createClass and React.PropTypes

hungrypipo avatar Feb 17 '18 01:02 hungrypipo

As far as I remember there are something else to fix. I've tried to rewrite only createClass/PropTypes and faced with a bunch of another issues which I had no time to deal with. So I just posted generic issue with some proofs here.

insolite avatar Mar 30 '18 13:03 insolite

Seeing as this one's not being maintained, the following might be a better option: https://github.com/andrerpena/react-mde

EDIT: Nevermind, I looked at the other one and get the idea that the developer is overengineering; it doesn't seem to have much additional functionality, yet uses like 10 times as many files to do it. (and ~3 times as many lines) Probably better just to patch up this one.

Venryx avatar Apr 12 '18 18:04 Venryx

@Venryx the other one you mentioned (https://github.com/andrerpena/react-mde) uses Draft.js as the editor front end, so it has a lot more functionality than this project (revisions/history, pasting of files, images, links, removal by block, etc). So it's not just wasted extra files -- Draft.js is somewhat opinionated, but does a lot of heavy lifting. (Just dropping this as a note for anyone else encountering this project's issue and thinking of jumping ship.)

brandonrobertz avatar Apr 16 '18 22:04 brandonrobertz

Any update on this ? :(

johnsonsamuel avatar May 28 '18 08:05 johnsonsamuel

@johnsonsamuel I ended up working around this by using https://github.com/sstur/react-rte as an editor and https://github.com/rexxars/react-markdown as the renderer. They're both React first and have XSS safety unlike this module and https://github.com/andrerpena/react-mde

brandonrobertz avatar May 28 '18 18:05 brandonrobertz