Check next props value against code mirror value

[durran]

We we having the same issues as described in https://github.com/JedWatson/react-codemirror/issues/121 and https://github.com/JedWatson/react-codemirror/issues/106. In our case, simply checking the next prop's value against the current code mirror value resolved the issue.

[OsamaShabrez]

Waiting for this PR to be merged. This solves our problem as well.

[marcofugaro]

please @JedWatson

[marcofugaro]

@durran I think also the file lib/Codemirror.js needs to be updated, that is the one being used when you require the library. I don't understand the workflow but you probably need to launch just npm run build

[inoas]

We are waiting for this (or https://github.com/JedWatson/react-codemirror/issues/107) to merge and considering moving to https://github.com/securingsincity/react-ace if there is nothing happening anytime soon cause we do not want to create a real fork.

[durran]

@marcofugaro I wasn't sure of the workflow as well so figure the build would be handled by @JedWatson before the publish.

[besh]

@JedWatson Just pinging because it looks like others were pinging with lowercase jedwatson which didn't appear to be performing the @mention.

Many have been needing the changes either in this PR or in #107. Are you open to having others help maintain this repo? We love everything you've done with it so far and I personally wouldn't want to have to rely on a random branch or switch to a different lib.

[christopherdro]

@JedWatson

[christopherdro]

Unfortunately this did not solve #106 for me.

[inoas]

Are you sure? Does https://github.com/JedWatson/react-codemirror/pull/107 fix it for your @christopherdro

[christopherdro]

Yes #107 works

[inoas]

Edit: Please try https://github.com/scniro/react-codemirror2 instead. That fork is maintained, available via npm and gathering stars.