JanusGraph
Redis integration #3018
- :white_check_mark: login: washerath / name: Wasantha Herath (5b224c4556a9e98c626a34e72b721093d411ceac)
- :x: The email address for the commit (9b24db521e2fd45e010402ef7e7147d039832998, 96949e43595afe6fc46c7c957667d8f8d1c66112) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Please verify the committer name, email, and GitHub username association are all correct and match CLA records.
@washerath Thank you for your contribution! A few things to notice:
-
EasyCLAis failing because you need to sign a CLA under Linux Foundation. The bot is complaining that it cannot find your user id, so that it cannot direct you to the CLA sign page. In order to fix this, you need to make sure you do your git commits using your GitHub account. Otherwise, GitHub cannot link your commit to your account. Then the bot should be able to proceed and guide you to sign your CLA. See this for more details. - You also need to "sign" your commit by appending a
sign-offmessage at the end of each commit. You can take a look at any other commit in the repository. You can also follow this guide. - For every new file, you need to add a Copyright header otherwise the CI won't proceed with the build. Take a look at any existing file in the repository.
- I remember you mentioned that you had to solve some performance issues. Do you have any statistics/benchmarks regarding the current performance with your Redis integration?
Please verify the committer name, email, and GitHub username association are all correct and match CLA records.
@washerath Just checking if you would like to proceed with this PR. Any help needed?
@li-boxuan Yes, I would like to contribute. As I see some checks have failed on my commit. I'll try to resolve them and try again.
@washerath Is it correct that this PR is still open or was it superseded by your new PR: #4180? Because in that case, we could close this one.
