jans icon indicating copy to clipboard operation
jans copied to clipboard
verified publisher icon JanssenProject

fix (jans-config-api) : some url fields have object value for oidc clients `GET` response

Open duttarnab opened this issue 3 years ago • 4 comments

Describe the bug For /jans-config-api/api/v1/openid/clients GET following url fields have object value.

  • clientUri
  • logoUri
  • policyUri
  • tosUri

Expected behavior The string values are expected for url fields.

duttarnab avatar Jul 12 '22 07:07 duttarnab

These fields are not strings anymore because it was moved to LocalizedString by Javier. It can't be represented with just string.

@duttarnab check this ticket for details https://github.com/JanssenProject/jans/issues/1057

https://github.com/JanssenProject/jans/blob/a8d0157b0a8664e5e4d58a9524a0fa20df324381/jans-orm/model/src/main/java/io/jans/orm/model/base/LocalizedString.java#L21

yuriyz avatar Jul 12 '22 09:07 yuriyz

LocalizedString changes under discussion with @yuriyz @yurem and @qbert2k

pujavs avatar Jul 13 '22 11:07 pujavs

I guess at the end we agree that simplification is needed as proposed by @yurem image

yuriyz avatar Jul 14 '22 08:07 yuriyz

@qbert2k, request you to please confirm once the LocalizedString changes as suggested by @yurem are implemented so that we can verify and test the impacted functionality.

pujavs avatar Jul 18 '22 08:07 pujavs

@duttarnab, @qbert2k seems to have fixed this. I tested locally and getting these values as string now. request you to please verify. image

pujavs avatar Nov 09 '22 12:11 pujavs

Fixed see https://github.com/JanssenProject/jans/issues/2946

pujavs avatar Dec 20 '22 19:12 pujavs