PyAutoGalaxy icon indicating copy to clipboard operation
PyAutoGalaxy copied to clipboard

Move install_requires from requirements.txt to setup.py

Open pllim opened this issue 3 years ago • 2 comments

Currently install_requires requirements are buried in a text file. Would be easier to discover if it is just done in setup.py . No reason to have file I/O overhead during setup for those entries.

Bonus: Move all that data from setup.py to setup.cfg for easier to read package info.

https://github.com/astropy/astropy.github.com/pull/491#issuecomment-1215349065

pllim avatar Aug 15 '22 16:08 pllim

We are going to adopt this: https://github.com/Jammy2211/PyAutoGalaxy/issues/67

Would listing all requirements and optional requirements in the pyproject.toml file satisfy this issue?

Jammy2211 avatar Nov 28 '22 10:11 Jammy2211

Yes, since I posted this, using pyproject.toml instead of setup.cfg is now popular. As long as you don't mind pinning to a much newer version of setuptools, I think that is the way to go now.

pllim avatar Nov 28 '22 14:11 pllim