ble-serial icon indicating copy to clipboard operation
ble-serial copied to clipboard

Scan timeout is not passed to deep scan

Open Quietus opened this issue 8 months ago • 1 comments

Note: for general support questions, please use the discussions tab. This is the template for bugs in ble-serial. Make sure you have completely read the README, searched through the issues and discussions.

Describe the bug When running a deep scan, the scan timeout is not passed to the deep scan - I can see that this was raised and addressed previously, but the changes in https://github.com/Jakeler/ble-serial/issues/30 are no longer present in version 3.0.0 (although they were helpful for writing a quick fix to apply the timeout locally).

Quietus avatar Jun 07 '25 21:06 Quietus

The code was reorganized in 3.0.0, but the timeout is still respected for the scan / waiting for advertisements, it goes through the same code path also on a deep scan. Then docs on the connect: Timeout in seconds passed to the implicit discover call when address_or_ble_device is not a BLEDevice - here it always uses a BLEDevice object now, so no implicit discover anymore => should not matter there.

Do you have an issue with deep scanning an actual device? If so please provide details

Jakeler avatar Sep 28 '25 01:09 Jakeler