Jacob Oaks

Results 53 comments of Jacob Oaks

Hey @asmeikal! I'd like to hear what other maintainers think, but I'm not necessarily opposed to creating a top-level `fx.Option` API that sets a default callback for an app. I'm...

Hey @asmeikal thanks for the update! This looks like a step in the right direction. I _do_ think we should stray away from having a separately stored callback at the...

Hey, thanks for the PR and sorry for the delay in response. We think this is a good idea in general, but we're worried about the extra verbosity. Do you...

Hey @marcelloh, thanks for reporting this issue. We'll follow up with nilaway maintainers on the best approach to resolving this.

Hey @mtoader thanks for the PR. I understand it does create friction to have two different import aliases within the same package for the same import, but can you elaborate...

Hey @feldentm-SAP, sorry for the confusion on the other PR. Not sure why github insists on it remaining closed. I think this could be a helpful addition. I'm not too...

Hey, this makes sense to us. We welcome anybody moving the PR here for our review.

Hey, can you provide us with a repro case for this so we can investigate further?

> lgtm with one minor behavioral improvement suggested Thank you for all your helpful review @abhinav!