Pathfinder icon indicating copy to clipboard operation
Pathfinder copied to clipboard

JNI crashes when trying to load invalid file

Open pjreiniger opened this issue 7 years ago • 0 comments

The C code segfaults if the FILE* fp pointer is null. I think the best thing to do would be having the read/write file classes do some defensive coding and check for null first. I was going to make a PR for that, but I saw #59, which is similar in concept, just higher up the chain.

It is a pretty cryptic crash that most students will probably not be able to figure out quickly, so I think it is a valuable update to make.

pjreiniger avatar Jan 31 '19 00:01 pjreiniger