Ivana Escobar
Ivana Escobar
Sounds good. I noticed the formatting of headers varies within `pkg/mypackage`, so I picked a single file as a template: `my package_init_varia.F`. The differences are in how the comments are...
> ### Closing NetCDF profiles-files? > 1. Are these files ever closed? Do they need to be closed? > 2. Does it make sense to replace the `NF_CLOSE`/`NF_OPEN` sequence by...
Added descriptive iterators in `pkg/profiles` to help with source code readability. `k` was overused, making S/R s confusing to follow. I tried to stay consistent in the entire package, but...
@mjlosch i’ll clean up the error handling messages today and ask you review it
**note:** I combined a do loop in two spots, contained in this commit: [02a7121](https://github.com/MITgcm/MITgcm/pull/887/commits/02a712185a9d364ef0c7b5de347b9cd302ee03cd) https://github.com/MITgcm/MITgcm/blob/9edc0e3a857b43485e78a68afe1fead7138321b8/pkg/profiles/profiles_init_fixed.F#L633-L635 and https://github.com/MITgcm/MITgcm/blob/9edc0e3a857b43485e78a68afe1fead7138321b8/pkg/profiles/profiles_readparms.F#L214-L216
Works for, ``` ./testreport -t global_oce_biogeo_bling -ncad -adm (-devel) ``` with a modified `input_ad/data.profiles` by adding ``` profilesDoNcOutput=.true., ``` gives the same gradient check results as the default **Note:** `pkg/profiles`...
I am not sure why the `bi/j` loops are limited as noted. Those ranges have been untouched since I started tinkering in this package. Is the new nomenclature to do...
@Shreyas911 seems relevant since you wanted access to TLM model equivalents written by the `profiles` package.
@mjlosch The missing `g_zero_adj.F` appeared when checking with the `verification_other` models: - `global_oce_cs32` - `global_oce_llc90` I couldn't run the executables from those set-ups because it looks like I'm missing some...
I’m having strange behavior from `grdchk` whether profiles is turned on or not. Thanks for sharing the forcing fields info! I’ll try it out to see if I get the...