DomoPhoenixHotReload umbrella compatibility
These changes ensure that this compiler module also works in the context of umbrellas. We are currently using this Version in one of our Umbrellas.
Thanks for continously improving domo, it helps our Team to quickly write simple and typesafe code.
Hey @zetaron,
Thanks for the PR. I see that it checks that all projects in the umbrella run the :elixir compiler. Doesn't the :domo_phoenix_hot_reload run on a per-project basis in isolation?
Can you, please, give a minimum example app illustrating the bug you experience in regard to this PR?
@IvanRublev Hey I setup a reproduction repo over at zetaron/domo-umbrella-reproduction. If you got any questions, requests or comments feel free to let me know :)
I hope this helps.
Hey @IvanRublev is it possible to reproduce the Issue with the repository I've setup? Are there any oversigths on my side regarding the projects configuration, that are obvious to you?
Hey, Thanks for the example project. I'll be able to have a look tomorrow.
Hey @IvanRublev is there antyhing I can help you with here?
Hey @zetaron, Thanks again for the example project and PR. Based on that I released version 1.5.9 which fixes the issue. Please, let me know if it works for you.
Thank you for your work. I will check it out on Monday 😀
@IvanRublev The problem ist solved with Release 1.5.9, thanks again.