Domo icon indicating copy to clipboard operation
Domo copied to clipboard

DomoPhoenixHotReload umbrella compatibility

Open zetaron opened this issue 3 years ago • 2 comments

These changes ensure that this compiler module also works in the context of umbrellas. We are currently using this Version in one of our Umbrellas.

Thanks for continously improving domo, it helps our Team to quickly write simple and typesafe code.

zetaron avatar Sep 21 '22 14:09 zetaron

Hey @zetaron, Thanks for the PR. I see that it checks that all projects in the umbrella run the :elixir compiler. Doesn't the :domo_phoenix_hot_reload run on a per-project basis in isolation?

Can you, please, give a minimum example app illustrating the bug you experience in regard to this PR?

IvanRublev avatar Oct 02 '22 13:10 IvanRublev

@IvanRublev Hey I setup a reproduction repo over at zetaron/domo-umbrella-reproduction. If you got any questions, requests or comments feel free to let me know :)

I hope this helps.

zetaron avatar Oct 10 '22 12:10 zetaron

Hey @IvanRublev is it possible to reproduce the Issue with the repository I've setup? Are there any oversigths on my side regarding the projects configuration, that are obvious to you?

zetaron avatar Oct 20 '22 15:10 zetaron

Hey, Thanks for the example project. I'll be able to have a look tomorrow.

IvanRublev avatar Oct 22 '22 15:10 IvanRublev

Hey @IvanRublev is there antyhing I can help you with here?

zetaron avatar Nov 10 '22 13:11 zetaron

Hey @zetaron, Thanks again for the example project and PR. Based on that I released version 1.5.9 which fixes the issue. Please, let me know if it works for you.

IvanRublev avatar Nov 12 '22 11:11 IvanRublev

Thank you for your work. I will check it out on Monday 😀

zetaron avatar Nov 12 '22 13:11 zetaron

@IvanRublev The problem ist solved with Release 1.5.9, thanks again.

zetaron avatar Nov 14 '22 10:11 zetaron