Ivan Carvalho
Ivan Carvalho
I think this can be fixed. We haven’t tested the Matplotlib drawing with inputs that deviate much from changing edge color and node color, to be honest. But the example...
I will drop this more as a FYI: check https://github.com/mlc-ai/tokenizers-cpp There's an existing C++ bindings from Tokenizers that goes through the same Rust -> C -> C++ path. The C++...
We had this discussion in #401 and I think that adding `Optional` was the possibly wrong solution we came at the time. The best solution would to have a specialization...
Optional named arguments from Option 1 are the best solution. If I had to pick an option it would be that one, I would approve a PR if you submitted...
With that being said `remove_self_loops` sounds like a potentially useful method. The `to_graph` method should already exist?
This seems to be a rather niche format, but I’d accept PRs implementing it. We can implement it from scratch or fork https://crates.io/crates/graph6-rs and adapt it to use petgraph’s graph...
I will still complete the review. But compared to other JOSS reviews, the pre-review for this had an unfavourable 6 week gap that covered when I had budgeted for the...
## Review checklist for @IvanIsCoding ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/main/COI.md) and that: I have no COIs...
@editorialbot generate pdf
This fails MSRV, I guess hashbrown will be stuck as well