react-native-sdk icon indicating copy to clipboard operation
react-native-sdk copied to clipboard

fix gradle config to inherit values from parent project using safextget

Open shamilovtim opened this issue 3 years ago • 1 comments

🔹 JIRA Ticket(s) if any

N/A external

✏️ Description

Please provide a brief description of what this pull request does.

Currently we are having to patch the plugin because the gradle build config is hardcoding values rather than inheriting them from the parent project. I applied the standard safeExtGet code popular in most gradle configs to inherit the parent values with a fallback. Otherwise user's projects will error out due to the hardcoding and users must patch the plugin to keep building.

shamilovtim avatar Jul 12 '22 00:07 shamilovtim

What's it take to merge this? @roninopf

shamilovtim avatar Sep 07 '22 15:09 shamilovtim

@evangreer91 could you please merge this? It's harmless and would eliminate a patch file for us.

shamilovtim avatar Dec 15 '22 16:12 shamilovtim