JWT improvements Part 1
- Provide a method to stop JWT retries (regardless of retry policy)
- Make it possible to specify a retry policy (on IterableConfig)
🔹 Jira Ticket(s) if any
✏️ Description
Please provide a brief description of what this pull request does.
Codecov Report
Attention: Patch coverage is 65.78947% with 13 lines in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
feature/JWTImprovement@e95295f). Click here to learn what that means.
:exclamation: Current head 680b6fa differs from pull request most recent head 3bfe86d. Consider uploading reports for the commit 3bfe86d to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## feature/JWTImprovement #718 +/- ##
=========================================================
Coverage ? 61.73%
=========================================================
Files ? 76
Lines ? 4728
Branches ? 536
=========================================================
Hits ? 2919
Misses ? 1506
Partials ? 303
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Added some comments @hardikmashru ! Really great PR. Can we have a feature branch and first have all the changes merged into the feature branch first? That way we can test the entire branch once ready and then merge to master
Thanks. Yes, I can merge all into the one feature branch after other 2 points are done. What will be the name of the branch?
Added some comments @hardikmashru ! Really great PR. Can we have a feature branch and first have all the changes merged into the feature branch first? That way we can test the entire branch once ready and then merge to master
Thanks. Yes, I can merge all into the one feature branch after other 2 points are done. What will be the name of the branch?
-> feature/JWTRetryEnhancement
@hardikmashru , lets have the base branch be a feature branch instead of master. Changes are looking great.
However, I still see that retries firing off instantly and not respecting time intervals set especially when SDK makes getMessages, getEmbeddedMessages and registerDevice call in the app startup.
Github actions - Checkstyle and a breaking unit test to be fixed before this can be merged in
Instrumentation test fails due to yml changes which are there in master branch. And the changes has not propagated to feature/JWTImprovement. Hence skipping the instrumentation test.