iterable-android-sdk icon indicating copy to clipboard operation
iterable-android-sdk copied to clipboard

JWT improvements Part 1

Open hardikmashru opened this issue 1 year ago • 5 comments

  1. Provide a method to stop JWT retries (regardless of retry policy)
  2. Make it possible to specify a retry policy (on IterableConfig)

🔹 Jira Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

hardikmashru avatar Apr 03 '24 13:04 hardikmashru

Codecov Report

Attention: Patch coverage is 65.78947% with 13 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (feature/JWTImprovement@e95295f). Click here to learn what that means.

:exclamation: Current head 680b6fa differs from pull request most recent head 3bfe86d. Consider uploading reports for the commit 3bfe86d to get more accurate results

Files Patch % Lines
.../com/iterable/iterableapi/IterableAuthManager.java 47.36% 7 Missing and 3 partials :warning:
.../java/com/iterable/iterableapi/IterableConfig.java 50.00% 2 Missing :warning:
...ain/java/com/iterable/iterableapi/IterableApi.java 75.00% 1 Missing :warning:
Additional details and impacted files
@@                    Coverage Diff                    @@
##             feature/JWTImprovement     #718   +/-   ##
=========================================================
  Coverage                          ?   61.73%           
=========================================================
  Files                             ?       76           
  Lines                             ?     4728           
  Branches                          ?      536           
=========================================================
  Hits                              ?     2919           
  Misses                            ?     1506           
  Partials                          ?      303           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 03 '24 13:04 codecov[bot]

Added some comments @hardikmashru ! Really great PR. Can we have a feature branch and first have all the changes merged into the feature branch first? That way we can test the entire branch once ready and then merge to master

Thanks. Yes, I can merge all into the one feature branch after other 2 points are done. What will be the name of the branch?

hardikmashru avatar Apr 03 '24 14:04 hardikmashru

Added some comments @hardikmashru ! Really great PR. Can we have a feature branch and first have all the changes merged into the feature branch first? That way we can test the entire branch once ready and then merge to master

Thanks. Yes, I can merge all into the one feature branch after other 2 points are done. What will be the name of the branch?

-> feature/JWTRetryEnhancement

Ayyanchira avatar Apr 03 '24 14:04 Ayyanchira

@hardikmashru , lets have the base branch be a feature branch instead of master. Changes are looking great.

However, I still see that retries firing off instantly and not respecting time intervals set especially when SDK makes getMessages, getEmbeddedMessages and registerDevice call in the app startup.

Ayyanchira avatar Apr 09 '24 04:04 Ayyanchira

Github actions - Checkstyle and a breaking unit test to be fixed before this can be merged in

Ayyanchira avatar Apr 19 '24 09:04 Ayyanchira

Instrumentation test fails due to yml changes which are there in master branch. And the changes has not propagated to feature/JWTImprovement. Hence skipping the instrumentation test.

Ayyanchira avatar May 13 '24 16:05 Ayyanchira