HeartRate-iOS-SDK icon indicating copy to clipboard operation
HeartRate-iOS-SDK copied to clipboard
verified publisher icon ItamarM

Not working on iPhone X

Open buechner opened this issue 8 years ago • 2 comments

I have tested your library on iPhoneX. It shows "waiting for bpm results" for a few seconds and than nothing happens. It must have something to do with the new camera.

Also, there is a bug with the flashlight. On iPhone X, 8 and 8s it must be activated after the capture session was started.

buechner avatar Jan 15 '18 14:01 buechner

I solved this and have consistent results between old and new iPhones by...

  1. Changing line 322 in HeartRateKitController to if (red < 100) {
  2. Changing line 9 in HeartRateKitController to #define kShouldAbortAfterSeconds 10

mellinger avatar Mar 12 '18 02:03 mellinger

@mellinger maybe you can PR this and I will merge?

ItamarM avatar Apr 23 '18 15:04 ItamarM