Generative-ABSA icon indicating copy to clipboard operation
Generative-ABSA copied to clipboard

code is incomplete in main.py line 332。

Open scarydemon2 opened this issue 4 years ago • 3 comments

the evaluate func is define as : def evaluate(data_loader, model, paradigm, task, sents): but parameter not passed in :https://github.com/IsakZhang/Generative-ABSA/blob/8f4671b2a4cbda6ebca1ab1462a4ce7607e0aed1/main.py#L332 It seems that the eval process is not finished, can you add the complete code?

scarydemon2 avatar Jan 19 '22 12:01 scarydemon2

you can try below code like test code : sents, _ = read_line_examples_from_file(f'data/{args.task}/{args.dataset}/dev.txt') dev_result = evaluate(dev_loader, model, args.paradigm, args.task, sents)

CodeWang-Ay avatar Apr 18 '22 07:04 CodeWang-Ay

Thanks @kingbuff for answering the question. Since I did not use "do_eval" in the final experiment, I forgot to change the code of that part when releasing. You can modify that part similar to "do_direct_eval". I will update the code later when I have more free time. Thanks.

IsakZhang avatar Apr 19 '22 03:04 IsakZhang

Do the experimental results of the ASTE task in your paper report a development set or a test set?

CodeWang-Ay avatar May 03 '22 05:05 CodeWang-Ay