contracts
contracts copied to clipboard
Security Review #350 : Exclude BC fee from balances
This issue is linked to
- Security Review with PR #350
Explanation
The current implementation does not exclude the collected fee from the balances. This behaviour results in the balances not tracking the real in and outflow of collateral/issuance tokens, creating unwanted behaviour. The decision was made to exclude the fee from the virtual balances as they get updated, as well as track the fee in a separate state within the implementation contract
Category:
- Low severity / Information issue
Link to review comments
- [x] https://github.com/InverterNetwork/inverter-contracts/pull/350#discussion_r1360643084