Change the default audio download

Open Felzow47 opened this issue 3 years ago • 1 comments

as explained in the video, the default format should be .wav or we can change it... your extension is incredible but there is just this little problem... (https://user-images.githubusercontent.com/49567056/197886948-7f00ae2a-8554-4cfa-a1dd-569fc0649f18.mp4) thx in advice

Oct 25 '22 21:10 Felzow47

I'm trying to do it myself but I block I probably managed to change the audio format but I can't compile the extension in zxp or another format so that it works but I I always have this damn html error... which suddenly blocks me and I can't use it and see if I succeeded...

but when i add the file the extension won't show up so im blocked

i think the page load ? but the app don't start ?

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>snatch</title>
    <script src="./CSInterface.js"></script>
    <script>
      if (window.__adobe_cep__) window.require = require || cep_node.require;
    </script>
  </head>

  <body>
    <div id="app"></div>
    <!-- built files will be auto injected -->
  </body>
</html>

now I have to understand how this page works...

im just dumb Snatch is """working""" but stuck at determining best format... i think my format change does't work :'( and why im dumb ?

i was trying to make the extension work without doing a build i'm just stupid

let's try to get determining working !

New update :

determining best format working and snatching working but not format change 😢 still a shity mp3 not a m4a or a wav.... so i still have this import error....

error with error this issue is so long 😂

    outputPath() {
      // @NOTE - Could be replaced with dynamic formats, but it might be too taking things a bit too far
      return `${this.outputFolder}/${this.title}.mp${
        this.audioOnly ? "3" : "4"
      }`;
    },
  },

    } else if (this.audioOnly) {
      let audioFormats = ytdl
      .filterFormats(info.formats, "audioonly")
      .filter(
          (format) =>
            format.container == "m4a" &&
            format.hasVideo == false &&
            format.itag !== 141
      )

I think that one of these two part of code which poses a problem and which makes it download in .mp3 and give me a import error

always this import error.... but ! the format of the file is changed!!!!! mp1 😂

format change is a sucess but one problem... wav file downloaded with snatch won't go in the timeline...

btw i created a fork

format change is not really a sucess a juste rename the file extension..... but that a improvement

YEEEEEEEEEEEEEEES IT WORK !!!!! FINALY after two days of after two days! I'm a noob in dev... but I'm glad I made it.

Oct 31 '22 00:10 Felzow47