plutus
plutus copied to clipboard
`makeIsDataIndexed` applied unnecessarily to `newtype TxId`
master branch, commit a70812, file plutus-ledger-api/src/PlutusLedgerApi/V1/Tx.hs:
Line 63: TxId is a newtype, but on line 218: makeIsDataIndexed used for TxId
This seems odd and slightly wasteful: TxId is something simple and non-polymorphic, so why would we need to use unConstrData to get the underlying bytestring?
I suggest changing newtype -> data on line 63 if polymorphism of TxId is intentional, or removing makeIsDataIndexed on line 218.
Either change would make TxId consistent with all the other lifted types in the ledger api.