auto-sd-paint-ext icon indicating copy to clipboard operation
auto-sd-paint-ext copied to clipboard

ComposableLora & Cutoff Extensions not working with Krita Plugin

Open DreamOfGit opened this issue 2 years ago • 6 comments

Error running process: \stable-diffusion-webui\extensions\stable-diffusion-webui-composable-lora\scripts\composable_lora_script.py Traceback (most recent call last): File "\stable-diffusion-webui\modules\scripts.py", line 417, in process script.process(p, *script_args) TypeError: ComposableLoraScript.process() missing 3 required positional arguments: 'enabled', 'opt_uc_text_model_encoder', and 'opt_uc_diffusion_model'

To Reproduce just put any Lora in your Krita prompt.

DreamOfGit avatar Apr 03 '23 22:04 DreamOfGit

Whats the commit version for webUI? I'm aware at some point the script API changed. But also, can you check the error does not occur when using the webUI?

Interpause avatar Apr 04 '23 11:04 Interpause

Doesn't happen on WebUI, I have no errors with WebUI. I'm on HEAD / latest.

(The Krita dockers are much cleaner btw - I am only recently coming back to this extension, it's really nice to use, great job)

DreamOfGit avatar Apr 04 '23 14:04 DreamOfGit

Hm, so LoRAs might be an always enabled script that injects into script args. When the frontend makes the API request, it wouldn't know the script args for LoRA. I guess the easiest way would be to detect for the LoRA script in my backend and just set it to always be enabled in the frontend.

Interpause avatar Apr 08 '23 05:04 Interpause

I have my webui to be auto updated and I'm on the controlnet commit of this krita extension and my Lora's don't throw any errors when I type the <lora:xyz> then trigger word on my prompts for generating on both img2img and txt2img on their respective dockers.

Might be because of your extension that interferes with the native Lora implementation? I don't have that installed image

rexelbartolome avatar Apr 09 '23 02:04 rexelbartolome

Can confirm. That extension was the issue.

After disabling it, I ran into a new error with the 'cutoff' extension

Error running process: \stable-diffusion-webui\extensions\sd-webui-cutoff\scripts\cutoff.py Traceback (most recent call last): File "\stable-diffusion-webui\modules\scripts.py", line 417, in process script.process(p, *script_args) TypeError: Script.process() missing 8 required positional arguments: 'enabled', 'targets_', 'weight', 'disable_neg', 'strong', 'padding', 'intp', and 'debug'

I think this lowers the priority of this issue quite a bit. Composables and Cutoff are pretty useful integrations.. but they are not the base web-ui.. so this issue is more QOL / Nice-to-have.. not a fundamental issue.

Good catch @rexelbartolome .

Thanks for reading / following up @Interpause

DreamOfGit avatar Apr 09 '23 19:04 DreamOfGit

Updating Issue title to be more accurate.

DreamOfGit avatar Apr 09 '23 19:04 DreamOfGit