lmdeploy icon indicating copy to clipboard operation
lmdeploy copied to clipboard

fix(ascend): fix import error of pt engine in cli

Open CyCle1024 opened this issue 1 year ago • 1 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

fix import error of pytorch engine 'ascend' device_type in cli

Modification

Please briefly describe what modification is made in this PR.

add deeplink env check and import in check_env

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

CyCle1024 avatar Aug 19 '24 03:08 CyCle1024

Require https://github.com/InternLM/lmdeploy/pull/2321 merged first.

CyCle1024 avatar Aug 19 '24 03:08 CyCle1024