AdBlockDetection icon indicating copy to clipboard operation
AdBlockDetection copied to clipboard

Adblock Plus "Disable on this Site only" with wrong detection (sometimes)

Open christianhaller opened this issue 9 years ago • 3 comments

Hi, the detection is not reliable, when the user has Adblock Plus (2.7.2) running in the mode "Disable on this page" only.

In the gif, you can see the race condition.

abp-bug

Actual result: inconsistent

Expected result: "Adblock is disabled"

Firefox 45, OS X 10.11.14

christianhaller avatar Apr 20 '16 12:04 christianhaller

cc @andrevollmer :)

christianhaller avatar Apr 20 '16 15:04 christianhaller

The script has been updated with the fix. Please checkout the latest code. Note: The analytics script along with the fix will be update soon.

iabmayank avatar Jun 27 '16 15:06 iabmayank

Hi, what was actually changed or fixed?

Br, Martti Alma Media Finland

From: Mayank Mishra [mailto:[email protected]] Sent: 27. kesäkuuta 2016 18:36 To: InteractiveAdvertisingBureau/AdBlockDetection [email protected] Subject: Re: [InteractiveAdvertisingBureau/AdBlockDetection] Adblock Plus "Disable on this Site only" with wrong detection (sometimes) (#1)

The script has been updated with the fix. Please checkout the latest code. Note: The analytics script along with the fix will be update soon.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/InteractiveAdvertisingBureau/AdBlockDetection/issues/1#issuecomment-228783217, or mute the threadhttps://github.com/notifications/unsubscribe/AKhDGaRsxurQ3IDt8b8KHGZFh3SS1432ks5qP-3sgaJpZM4ILo6E.

marttihalme avatar Jun 29 '16 06:06 marttihalme