inn icon indicating copy to clipboard operation
inn copied to clipboard

Improve how perl-nocem parses NoCeM notices

Open Julien-Elie opened this issue 4 years ago • 1 comments

  • The Subject header field is not checked for the @@NCM string and there is no check for the presence of the References header field.

  • The accuracy of the newsgroups following the Message-IDs to cancel in the NoCeM body is not checked, nor is the Newsgroups pseudo header field if present.

(From the BUGS section of the perl-nocem man page.)

Julien-Elie avatar Oct 16 '21 14:10 Julien-Elie

Worthwhile documenting in an Internet-Draft, and share it to have comments, before changing anything.

Julien-Elie avatar Mar 19 '23 12:03 Julien-Elie

Checks added in https://github.com/InterNetNews/inn/commit/bfac2f225c510fb96e34d740b47c20066a06e57d for the Subject and References header fields. It is consistent with the legacy nocem-0.93 implementation.

Mention added in https://github.com/InterNetNews/inn/commit/28b13326eb299a9b4b5b0a278fd915d96f6c852b that there is no need to check the accuracy of the newsgroups mentioned in the NoCeM message. As we already decided to trust the issuer, let's be confident about the listed newsgroups.

Julien-Elie avatar Jun 13 '24 21:06 Julien-Elie