gb_visual_detection_3d icon indicating copy to clipboard operation
gb_visual_detection_3d copied to clipboard
verified publisher icon IntelligentRoboticsLabs

last_detection_ts_ time out in update loop should be configurable

Open AravindaDP opened this issue 5 years ago • 1 comments

https://github.com/IntelligentRoboticsLabs/gb_visual_detection_3d/blob/melodic/darknet_ros_3d/src/darknet_ros_3d/Darknet3D.cpp#L168 It's better to use a rosparam threshold instead hardcoded value of 2 seconds.

I'm happy to make a PR if this is a welcome enhancement.

AravindaDP avatar Nov 03 '20 14:11 AravindaDP

Yes, it should be a parameter. Feel free to make a PR if you want @AravindaDP

fgonzalezr1998 avatar Nov 13 '20 11:11 fgonzalezr1998