[draft] Allow Inventory Manager to list, pull, and push to player Curios slots

[Kurtoid]

closes SirEndii/Advanced-Peripherals-Features#8

[SirEndii]

One thing I noticed is, that you don't check if curios is loaded since it's a optional dependency

So if curios is not loaded, the game would crash when someone runs these functions

[SirEndii]

And ignore the failed github action, these currently do not work for pull requests

[SirEdvin]

I can suggest reusing peripheral plugin logic as environmental sensor do.

[Kurtoid]

One thing I noticed is, that you don't check if curios is loaded since it's a optional dependency

Would implementing this as a plugin handle that? I'll give it a try

[Kurtoid]

Making sure I understand correctly: I should move the Curios calls to a new class in common/addons/curios/, create a PERIPHERAL_PLUGINS like in the Environmental Sensor, and define and use InventoryManagerPeripheral.addIntegrationPlugin ?

Edit: wait, BasePeripheral has addPlugin - should I use that, or only call addPlugin at initialization like the Environmental Sensor? For now, I'll follow what the Environmental Sensor does as recommended by SirEdvin

[Kurtoid]

Just encountered this: https://github.com/TheIllusiveC4/Curios/issues/238 so this might not even be possible unless there's a workaround

[SirEndii]

Just encountered this: TheIllusiveC4/Curios#238 so this might not even be possible unless there's a workaround

Oh indeed, that's a issue

A workaround would be that we check the items before adding them

[SirEndii]

Edit: wait, BasePeripheral has addPlugin - should I use that, or only call addPlugin at initialization like the Environmental Sensor? For now, I'll follow what the Environmental Sensor does as recommended by SirEdvin

Yeah, do it like edvin recommended it

[SirEndii]

Any progress? I don't want to put you under pressure or give you time pressure I'm just asking because I'll release an update soon and want to know if I'll include your changes or not

[Kurtoid]

I don't think I'll have it ready soon - academics kicked back up. I have an idea on how to filter it, but making everything stable and all will take time

On Fri, Jul 7, 2023, 16:11 Srendi @.***> wrote:

Any progress? I don't want to put you under pressure or give you time pressure I'm just asking because I'll release an update soon and want to know if I'll include your changes or not

— Reply to this email directly, view it on GitHub https://github.com/SirEndii/AdvancedPeripherals/pull/480#issuecomment-1626015216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASLGEJ4JA3R7LLY5GNMMKLXPBUP7ANCNFSM6AAAAAAZ3TP4OU . You are receiving this because you authored the thread.Message ID: @.***>

[SirEndii]

Alright, no problem And thank you for the quick response

[SirEndii]

Greetings @Kurtoid Do you have any plans to work on this?

[Kurtoid]

Whoops, I took a break from minecraft and forgot about this. It looks like Curios now has the support needed to do this without workarounds (https://github.com/TheIllusiveC4/Curios/issues/238#issuecomment-1705847407). I'm not sure if I can do it in a timely manner, though

[SirEndii]

Greetings I will close this for now If anyone wants to implement this, feel free to just leave a message or create a new PR