feature: add flag for beacon effects of other plots

[DerEingerostete]

Overview

Adds a Plot Flag that enables players to disable beacon effects from other plots Fixes #3626

Description

Adds the new Plot Flag "beacon-effects" to toggle beacon effects from other plots. By default beacon effects from other plots are enabled but can be toggled off by setting this flag to false. Note: Works only on Paper (requires the BeaconEffectEvent from Paper)

Submitter Checklist

• [X] Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
• [X] Ensure that the pull request title represents the desired changelog entry.
• [X] New public fields and methods are annotated with @since TODO.
• [X] I read and followed the contribution guidelines.

[dordsor21]

I think it would also be a good idea to add a global prevention for beacon effects "leaking" out of plots, able to be enabled/disabled under the paper block in settings.yml (probably enabled by default). This way, beacons can still affect players in their own plot, but they will not be affected by beacons in other plots and vice versa.

[RedstoneFuture]

I'm not sure if the option/flag names are user-friendly. Now we have the following setup:

• Config option "BEACON_EFFECTS", true by default = Prevent cross plot beacon effects, if it's true
• Flag "BeaconEffect", true by default = Prevent cross plot beacon effects, if it's true

[DerEingerostete]

I'm not sure if the option/flag names are user-friendly. Now we have the following setup:

* Config option "BEACON_EFFECTS", `true` by default = Prevent cross plot beacon effects, if it's `true`

* Flag "BeaconEffect", `true` by default = Prevent cross plot beacon effects, if it's `true`

Should I remove the flag and only keep the setting or should we change the description for the flag?

[NotMyFault]

Works out nicely overall, thanks for addressing the outstanding concerns.

Minor nit: The settings.yml option should consider PlayerLeavePlotEvent, otherwise players can step on the plot, grab the effect and leave again, which kinda defeats the purpose of the flag.

[DerEingerostete]

Works out nicely overall, thanks for addressing the outstanding concerns.

Minor nit: The settings.yml option should consider PlayerLeavePlotEvent, otherwise players can step on the plot, grab the effect and leave again, which kinda defeats the purpose of the flag.

Okay will remember that and change it. Is this event an event working with the Bukkit EventHandler or do I need a special class/listener?

[dordsor21]

You can add it to the plotExit method in com.plotsquared.core.listener.PlotListener

[DerEingerostete]

You can add it to the plotExit method in com.plotsquared.core.listener.PlotListener

This saidly dosen't work because the player abstraction dosen't have a remove effect mathod. Should I add one or rather register a own listener in the Bukkit module?

[dordsor21]

It would probably be best to add it to the PlotPlayer

[NotMyFault]

Thanks for addressing the outstandign concerns, looks promising so far!

[NotMyFault]

What's the status of this PR? The changes requested have been addressed and there is no more blocking feedback that prevents a merge. Shall we include this in next week's release?

[NotMyFault]

No further reviews after an explicit request imply this PR is ready to go, thanks for your contribution!