FastAsyncWorldEdit icon indicating copy to clipboard operation
FastAsyncWorldEdit copied to clipboard

Commands using Selections now require Confirm label

Open Zeranny opened this issue 1 year ago • 1 comments

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

Changes in #3052 now require commands using selections to include @Confirm(Confirm.Processor.REGION). Not having this gives a pretty unfriendly error:

image

Previously you would just get the regular informative error:

image

I have tested adding the annotation to one command and it doesn't appear to cause issues with regular WorldEdit, so the change doesn't cause any compatibility issues.

To Reproduce

  1. Create a command which takes a Selection
  2. Do not add the Confirm annotation
  3. Run the command ingame without an active selection
  4. IllegalStateException error

Expected behaviour

Commands expecting a selection which do not recieve one should error instructively as before: image

Effectively, when no @Confirm(...) is present for the region, Confirm.Processor.REGION should be the default.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/d8e209464d4e4bcd85aec7766117481f

Fawe Version

FastAsyncWorldEdit-Bukkit-2.12.4-SNAPSHOT-1020

Checklist

  • [X] I have included a Fawe debugpaste.
  • [X] I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.

Anything else?

No response

Zeranny avatar Jan 13 '25 12:01 Zeranny

@eztaK-red correctly pointed out that the command manager isn't technically part of the API and is internal.

I have removed reference to this being an API issue, so this is more of a request than a bug report.

Zeranny avatar Jan 21 '25 16:01 Zeranny