FastAsyncWorldEdit icon indicating copy to clipboard operation
FastAsyncWorldEdit copied to clipboard

Bad calculation of the number of blocks changed?

Open jewome62 opened this issue 3 years ago • 3 comments

Server Implementation

Paper

Server Version

1.18.2

Describe the bug

I have currently some problems with max-changed limitation.

I have a rank named 'builder-plus' with 8 millions max-change

limits:
[some-line]
  builder-plus:
    # Max actions that can be run concurrently (i.e. commands)
    max-actions: 2
    # Max number of block changes (e.g. by `//set stone`).
    max-changes: 8000000
    # Max number of blocks checked (e.g. `//count stone` which doesn't change blocks)
    max-checks: 80000000
    # Number of times a change can fail (e.g. if the player can't access that region)
    max-fails: 4000000
    # Allowed brush iterations (e.g. `//brush smooth`)
    max-iterations: 500
[some-line]

But with //pos1 //pos2 and //set stone they are limited to 2.5 millions blocks.

I have checked, the permission is well configured, here exemple of luck perms record: image

To Reproduce

  1. Define limitation
  2. Check permission to be limited
  3. Try the limitation with simple //set stone

Expected behaviour

I suppose there are complicated to fix this kind of bug.

Many add some step into resolution of this bug : As add log or complete the error message with value compared (current max-changed of player and current selection count) ?

Screenshots / Videos

image

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/6e996039991c46ef9176dc2941395c5c

Fawe Version

FastAsyncWorldEdit-2.4.1

Checklist

  • [X] I have included a Fawe debugpaste.
  • [X] I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.

Anything else?

No response

jewome62 avatar Jul 14 '22 11:07 jewome62

Hi,

The same in 1.19.1 and the last version.

aurel85 avatar Aug 05 '22 22:08 aurel85

Same here, the plugin doesn't seem to use the max-changes value correctly FAWE debugpaste: https://athion.net/ISPaster/paste/view/35e51bf1a01d4b5cb86f2b692362a452 In this test I have max-changes: 2000000 and max-checks: 2000000 but I'm trying to do a worldedit operation that will only change 1.5 million blocks and it doesn't let me: 2022-08-16_14 25 42

A temporary fix is to just set the number way higher

SecretlyJealous avatar Aug 16 '22 13:08 SecretlyJealous

I don't think the max-changes feature has ever worked correctly to be honest.

MattBDev avatar Oct 20 '22 02:10 MattBDev