FastAsyncWorldEdit icon indicating copy to clipboard operation
FastAsyncWorldEdit copied to clipboard

Can't add more vertices to convex region after creating a line of vertices.

Open Zephy1 opened this issue 4 years ago • 5 comments

Server Implementation

Paper

Server Version

1.16.5

Describe the bug

When adding vertices to a convex region, if you add them in a line no other vertices will be added.

To Reproduce

Start a convex region selection. Add a vertex to the left. Add a vertex to the right. Try to add more vertices somewhere else (Part that doesn't work).

Expected behaviour

To add extra vertices.

Screenshots / Videos

https://user-images.githubusercontent.com/32806171/143670759-d7e2ff4d-fa56-4708-b5ea-f3651e390588.mp4

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/d477662482ef4101bb7031617300be0e

Fawe Version

1.17-409;11e2591

Checklist

  • [X] I have included a Fawe debugpaste.
  • [X] I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit-1.17/ and the issue still persists.

Anything else?

Still present using only FAWE. https://athion.net/ISPaster/paste/view/9e4d04e142b140e28755125c10fc14d8

Using the API to make a convex region then manually adding the points makes them appear using region.getVertices(), however, when trying to actually edit the region, only the original line of vertices is changed.

Zephy1 avatar Nov 27 '21 06:11 Zephy1

From my testing, this is an issue with WE too. Could you verify that?

The implementation uses triangles and calculates a normal vector for each of them. But as the cross product of two linear dependent vectors is zero, normalizing that vector will result in (NaN, NaN, NaN).

SirYwell avatar Nov 27 '21 07:11 SirYwell

Still present using WE 7.2.7 (Latest stable) and WE 7.2.8-SNAPSHOT #5982 (Latest experimental).

Zephy1 avatar Nov 27 '21 18:11 Zephy1

If that is an issue with WorldEdit as well, better report it to their issue tracker.

NotMyFault avatar Nov 27 '21 18:11 NotMyFault

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If the issue is still present and can be reproduced, please let the team know. Thank you for your contributions.

stale[bot] avatar Jan 06 '22 00:01 stale[bot]

https://github.com/EngineHub/WorldEdit/issues/1950

OneLiteFeather avatar Apr 16 '23 21:04 OneLiteFeather