dpctl icon indicating copy to clipboard operation
dpctl copied to clipboard

Remove use of `python setup.py develop/install` in the project

Open ndgrigorian opened this issue 5 months ago • 17 comments

A warning that python setup.py develop is deprecated and will no longer be supported at the end of October, 2025 has been ongoing for some time when using dpctl build driver scripts, and can be seen in the CI

This PR proposes instead relying on pip for installing dpctl in scripts, and reworks the scripts to maintain use of scikit-build

In the future, this will also simplify a transition to scikit-build-core

The PR also introduces options

  • --clean and --skip-editable to build_locally driver
  • --clean and --skip-pytest to gen_coverage driver
  • --clean to gen_docs driver
  • [ ] Have you provided a meaningful PR description?
  • [ ] Have you added a test, reproducer or referred to an issue with a reproducer?
  • [ ] Have you tested your changes locally for CPU and GPU devices?
  • [ ] Have you made sure that new changes do not introduce compiler warnings?
  • [ ] Have you checked performance impact of proposed changes?
  • [ ] Have you added documentation for your changes, if necessary?
  • [ ] Have you added your changes to the changelog?
  • [ ] If this PR is a work in progress, are you opening the PR as a draft?

ndgrigorian avatar Oct 15 '25 00:10 ndgrigorian

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. :crossed_fingers:

github-actions[bot] avatar Oct 15 '25 01:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_29 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 15 '25 01:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_29 ran successfully. Passed: 1116 Failed: 5 Skipped: 119

github-actions[bot] avatar Oct 15 '25 01:10 github-actions[bot]

Coverage Status

coverage: 86.276%. remained the same when pulling 796254182fcd2889fc87da123e431129c05d3116 on do-not-use-setup-py-develop into dd6f72abbd9cc66b1e3597af2eefb2d6680dbc43 on master.

coveralls avatar Oct 15 '25 01:10 coveralls

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_30 ran successfully. Passed: 1114 Failed: 7 Skipped: 119

github-actions[bot] avatar Oct 15 '25 05:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_30 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 15 '25 05:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_30 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 15 '25 06:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_32 ran successfully. Passed: 1116 Failed: 5 Skipped: 119

github-actions[bot] avatar Oct 15 '25 16:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_31 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 15 '25 16:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0=py310h93fe807_32 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 15 '25 21:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_33 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 28 '25 23:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_34 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 28 '25 23:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_34 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 28 '25 23:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_35 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 29 '25 00:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_31 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 30 '25 21:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_31 ran successfully. Passed: 1114 Failed: 7 Skipped: 119

github-actions[bot] avatar Oct 30 '25 21:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_31 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Oct 30 '25 21:10 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_34 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Nov 05 '25 23:11 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_34 ran successfully. Passed: 1116 Failed: 5 Skipped: 119

github-actions[bot] avatar Nov 05 '25 23:11 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_36 ran successfully. Passed: 1114 Failed: 7 Skipped: 119

github-actions[bot] avatar Nov 06 '25 09:11 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_37 ran successfully. Passed: 1114 Failed: 7 Skipped: 119

github-actions[bot] avatar Nov 06 '25 09:11 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_39 ran successfully. Passed: 1113 Failed: 8 Skipped: 119

github-actions[bot] avatar Nov 06 '25 16:11 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_43 ran successfully. Passed: 1112 Failed: 9 Skipped: 119

github-actions[bot] avatar Nov 06 '25 19:11 github-actions[bot]

Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_44 ran successfully. Passed: 1115 Failed: 43 Skipped: 82

github-actions[bot] avatar Nov 13 '25 02:11 github-actions[bot]