dpctl icon indicating copy to clipboard operation
dpctl copied to clipboard

Technical debt changes in indexing functions

Open ndgrigorian opened this issue 1 year ago • 5 comments

This PR cleans up indexing functions

  • Renames Python bindings from usm_ndarray_take and usm_ndarray_put to py_take and py_put to improve consistency with the rest of dpctl
  • Removes indexing mode macros, opting for a ternary check instead
  • Refactors to break up _populate_kernel_params internal function to improve code readability [WIP]
  • [X] Have you provided a meaningful PR description?
  • [ ] Have you added a test, reproducer or referred to an issue with a reproducer?
  • [ ] Have you tested your changes locally for CPU and GPU devices?
  • [ ] Have you made sure that new changes do not introduce compiler warnings?
  • [ ] Have you checked performance impact of proposed changes?
  • [ ] Have you added documentation for your changes, if necessary?
  • [ ] Have you added your changes to the changelog?
  • [X] If this PR is a work in progress, are you opening the PR as a draft?

ndgrigorian avatar Feb 21 '25 21:02 ndgrigorian

View rendered docs @ https://intelpython.github.io/dpctl/pulls/2012/index.html

github-actions[bot] avatar Feb 21 '25 22:02 github-actions[bot]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_537 ran successfully. Passed: 894 Failed: 2 Skipped: 118

github-actions[bot] avatar Feb 21 '25 22:02 github-actions[bot]

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_537 ran successfully. Passed: 895 Failed: 1 Skipped: 118

github-actions[bot] avatar Feb 22 '25 02:02 github-actions[bot]

Coverage Status

coverage: 86.381%. remained the same when pulling d409117d8d2b91992a5b797c3000bdf0c101d6a1 on technical-debt-indexing-fns into bc7a7392f1ed5adca473a784a37fd7126e67035d on master.

coveralls avatar Feb 22 '25 02:02 coveralls

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_115 ran successfully. Passed: 913 Failed: 1 Skipped: 154

github-actions[bot] avatar Apr 09 '25 04:04 github-actions[bot]