ITK icon indicating copy to clipboard operation
ITK copied to clipboard

ENH: Add distance with point ids in itkPointsLocator

Open PranjalSahu opened this issue 3 years ago • 4 comments

PR Checklist

  • [ ] No API changes were made (or the changes have been approved)
  • [ ] No major design changes were made (or the changes have been approved)
  • [X] Added test (or behavior not changed)
  • [X] Updated API documentation (or API not changed)
  • [ ] Added license to new files (if any)
  • [ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • [ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for further development details if necessary.

PranjalSahu avatar Jul 22 '22 15:07 PranjalSahu

Also, please add a relevant commit message body that explains the rationale of the changes. Thanks.

jhlegarreta avatar Jul 25 '22 12:07 jhlegarreta

@jhlegarreta Yes, I will do the suggested changes. I am checking if one of the functions can be removed from the codebase.

PranjalSahu avatar Jul 26 '22 03:07 PranjalSahu

@jhlegarreta I am adding a commit message regarding the removal of the Search method. That is important and should be present for future reference.

PranjalSahu avatar Aug 10 '22 19:08 PranjalSahu

As you are adding code, and 2 commits later removing some, it makes sense to squash these into a single commit. Less changes to look at that way.

Also, you should update the commit message to explain a little the reasoning behind changes.

dzenanz avatar Aug 10 '22 20:08 dzenanz