onyxia-api icon indicating copy to clipboard operation
onyxia-api copied to clipboard

Secretonyxia

Open fcomte opened this issue 1 year ago • 5 comments

This PR is intend to manage metadata of an onyxia release inside a secret with a owner reference pointing on the helm secret to ensure that those metadata will be remove when the release is deleted.

 onyxia@vscode-python-81650-0:~/work$ kubectl get secrets
user-xxxxx                  sh.onyxia.release.v1.jupyter-pyspark-706716                  onyxia.sh/release.v1

This PR also create two endpoint to modify the friendly name and the shared status of an existing release. This PR also modify attributes of a release ( to add thoses metadata : owner , share, friendlyname and catalogID ) and the body of the request when a user create a release.

fcomte avatar May 15 '24 16:05 fcomte

Hi! Can you give a brief description of what this PR introduce? 😊

johnksv avatar May 16 '24 08:05 johnksv

This PR modify how we manage metadata for specific onyxia information. Before this PR those metadata (owner, share, friendly name) was kept inside helm values. This PR manage those metadata inside onyxia specific secrets. Those secrets are deleted if thé release IS delete without onyxia because of the ownerReference referencing the helm release secrets

fcomte avatar May 16 '24 10:05 fcomte

It will also enable the modification of friendly name ans the sharing status without update the release

fcomte avatar May 16 '24 10:05 fcomte

This looks ok to me.
@johnksv any remark on this PR ?

olevitt avatar May 21 '24 11:05 olevitt