zola-hook icon indicating copy to clipboard operation
zola-hook copied to clipboard

feat: support code line number, rewrite table, and some tiny bug fix.

Open cscnk52 opened this issue 1 year ago • 1 comments

e28bbb9 - style: format use scss formater da529bb - fix(title): add padding top for better distinguish title and main text 95712b2 - fix(body): change line-height to 1.5rem for a better chinese render. 497b3bd - feat(code): support line number for code(not support highlight line) 475abc6 - feat(inline-code): add rounded corner for inline code 51300df - feat(table): rewrite table style, add hover highlight

All caption was written in git commit message, please consider merge.

About table: my post in https://blog.cscnk52.me/blog/scoop/. before: image After: PixPin_2025-03-11_17-30-45

cscnk52 avatar Mar 11 '25 09:03 cscnk52

Hi, thanks for the PR!

Some of these changes seem particular to your personal use of the theme (e.g. line height, table style). Instead of changing the main theme, you can include an additional stylesheet in your site to apply those changes.

For the rest, I would suggest splitting into separate PRs so it's easier to review and change:

  • code line numbers: I would love to add this, but it also needs support for line highlights;
    • this PR can also include rounded borders for inline code
  • title padding: seems like a good idea;
  • code formatting: not sure, would need to set up auto-formatting probably. Which formatter did you use?

InputUsername avatar Mar 16 '25 14:03 InputUsername