InnerSourcePatterns icon indicating copy to clipboard operation
InnerSourcePatterns copied to clipboard

docs(known-instances): Added SAP to RFC pattern

Open dellagustin-sap opened this issue 1 year ago • 3 comments

dellagustin-sap avatar Apr 11 '24 13:04 dellagustin-sap

Thank You Banner

:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! :checkered_flag:

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

welcome[bot] avatar Apr 11 '24 13:04 welcome[bot]

@michael-basil , you asked if SAP could be included as known instance, you may want to review this PR.

dellagustin-sap avatar Apr 11 '24 13:04 dellagustin-sap

I recommend to squash this when merging, as I had to send a commit to fix a linter finding.

dellagustin-sap avatar Apr 11 '24 13:04 dellagustin-sap

Congratulations Banner Congrats on merging your first pull request! :tada: We here at The InnerSource Commons are proud of you! :sparkling_heart: Thank you so much for your contribution :gift:

welcome[bot] avatar Dec 11 '24 18:12 welcome[bot]