llmaz icon indicating copy to clipboard operation
llmaz copied to clipboard

[Umbrella] Improve test coverages

Open kerthcet opened this issue 1 year ago β€’ 8 comments

This is the currently unit test coverage:

βˆ…  api/core/v1alpha1 (64ms)
βˆ…  pkg (5ms)
βˆ…  api/inference/v1alpha1 (43ms)
βˆ…  pkg/controller (33ms)
βˆ…  pkg/cert (78ms)
βˆ…  pkg/controller/inference (28ms)
βˆ…  pkg/webhook (23ms)
βœ“  pkg/controller_helper/model_source (1.014s) (coverage: 4.8% of statements)
βœ“  pkg/controller_helper (2.011s) (coverage: 3.6% of statements)
βœ“  pkg/util (3.184s) (coverage: 5.8% of statements)

We need to improve this.

kerthcet avatar Sep 12 '24 07:09 kerthcet

/kind cleanup

kerthcet avatar Sep 12 '24 07:09 kerthcet

/good-first-issue

kerthcet avatar Sep 12 '24 07:09 kerthcet

I am trying to get involved and familiar with this project, I am willing to help /assign

googs1025 avatar Sep 13 '24 09:09 googs1025

Thanks @googs1025

kerthcet avatar Sep 13 '24 11:09 kerthcet

I want to try it. @kerthcet

X1aoZEOuO avatar May 22 '25 02:05 X1aoZEOuO

Feel free to take it. /assign @X1aoZEOuO

kerthcet avatar May 22 '25 03:05 kerthcet

Hi, I'm new here and would like to help with improving the test coverage. I can start with the pkg/controller_helper/model_source package. Is there anything I should know before I start?

yangyuwen-bri avatar Jun 29 '25 16:06 yangyuwen-bri

I think the basic principle is that it should be table-driven testing, just like: https://github.com/InftyAI/llmaz/blob/cf3283f6350711a81942371979f03f56d533a44b/pkg/controller_helper/backendruntime/backendruntime_test.go#L33-L39

kerthcet avatar Jun 29 '25 22:06 kerthcet