Private_Tab_WE icon indicating copy to clipboard operation
Private_Tab_WE copied to clipboard

Not compatible with Firefox Quantum

Open vic4key opened this issue 8 years ago • 9 comments

Hi @Infocatcher,

This add-on is now not compatible with Firefox Quantum. Could you please spend time to update it as soon as possible? I very like your add-on, it's very useful. Thanks you so much.

Best Regards, Vic P.

vic4key avatar Dec 01 '17 15:12 vic4key

Look at the README, there are 2 blocking bugs on Firefox's side. Not much the author can do unless they contribute directly to firefox itself.

ghost avatar Dec 02 '17 18:12 ghost

Oops. Hope to be able to find a good solution for this. Thanks.

vic4key avatar Dec 02 '17 20:12 vic4key

Check this out: https://github.com/stoically/firefox-add-on-temporary-containers

anewuser avatar Feb 04 '18 04:02 anewuser

Check this out: https://github.com/stoically/firefox-add-on-temporary-containers

Hmm... as I see, still used something custom to remove history entries. Store each visited URL: https://github.com/stoically/firefox-add-on-temporary-containers/blob/ea04a06af2d40d04e4f0c6960e1e6761cedc6f05/src/background/request.js#L33-L44 And then remove them: https://github.com/stoically/firefox-add-on-temporary-containers/blob/ea04a06af2d40d04e4f0c6960e1e6761cedc6f05/src/background/container.js#L227-L237 Better, than nothing, but also will be removed regular history, if will be opened the same URL in non-private and "private" mode/container. :(

Infocatcher avatar Feb 04 '18 12:02 Infocatcher

That's because of https://bugzilla.mozilla.org/show_bug.cgi?id=1283320.

Apart from than that, he's added many combinations of options and has plans for adding more. Maybe you should collaborate with him with your ideas and experience to make it as efficient as possible instead of having to reinvent the wheel?

anewuser avatar Feb 04 '18 15:02 anewuser

Seem it cleans sth. Not able to use normal mode and private together.

vic4key avatar Feb 04 '18 15:02 vic4key

@vic4key Disable the automatic mode in the settings.

anewuser avatar Feb 04 '18 16:02 anewuser

Great. Thank you so much, bro.

vic4key avatar Feb 04 '18 17:02 vic4key

@Infocatcher

Better, than nothing, but also will be removed regular history, if will be opened the same URL in non-private and "private" mode/container. :(

Yeah, it's also explicitly mentioned as a big red warning in the opt-in advanced preferences that exactly that happens until history support for containers is added.

Also, if you're interested, I'd be absolutely open to collaborate. Just let me know if I can be of any help if you consider starting the WebExtension Development.

@vic4key Sorry for the hassle, I'll try to make the on-boarding easier.

Thanks @anewuser for helping out!

stoically avatar Feb 07 '18 17:02 stoically