InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard
verified publisher icon InfiniTimeOrg

Make it possible to dismiss new notifications in the preview screen

Open tgc-dk opened this issue 3 years ago • 3 comments

Make it possible to dismiss new notifications in the preview screen with SwipeRight, as suggested in #1232.

tgc-dk avatar Sep 14 '22 20:09 tgc-dk

A screencast of the new behavior: InfiniSim_2022-09-16_200901

tgc-dk avatar Sep 16 '22 20:09 tgc-dk

cool! you implemented the notification overlay. Could you make a PR in InfiniSim for that? That was on my todo-list for exactly solving this issue. Thanks in advance :bow:

NeroBurner avatar Sep 19 '22 20:09 NeroBurner

cool! you implemented the notification overlay. Could you make a PR in InfiniSim for that? That was on my todo-list for exactly solving this issue. Thanks in advance bow

I've made a PR in InfiniSim with my changes, I hope it is useful: InfiniTimeOrg/InfiniSim/pull/68

tgc-dk avatar Sep 20 '22 21:09 tgc-dk

I've rebased the PR against the latest develop-branch.

tgc-dk avatar Oct 04 '22 18:10 tgc-dk

I've just tested this branch on my PineTime, and it crashes when I dismiss the notification while previewing. Did you test the last changes on the actual hardware?

JF002 avatar Oct 10 '22 15:10 JF002

I've just tested this branch on my PineTime, and it crashes when I dismiss the notification while previewing. Did you test the last changes on the actual hardware?

It does not crash on my PineTime.... Does it crash everytime, or only once in a while?

tgc-dk avatar Oct 11 '22 11:10 tgc-dk

just rebased this PR on current develop eb0af22ecf66957b9341521990c49a6d1d5d70e3 Watch face settings : disable watch faces that are not available (external resources are not installed).

And dismiss works for me on PineTime (no resource pack installed, PTS-watch-face)

(also tested on InfiniSim)

NeroBurner avatar Oct 11 '22 20:10 NeroBurner

Dismissing works for me as well when adding this to 1.11. No resource pack, tested all 4 standard watch faces.

Commenter25 avatar Oct 16 '22 18:10 Commenter25

Also works fine for me, had no crash after using it for 3 days.

ghost avatar Nov 22 '22 04:11 ghost

Well, I'm confused, it's still crashing on my setup :/

https://user-images.githubusercontent.com/2261652/209581121-744ca51d-a4aa-48a7-bfad-bf4862ebc1b8.mp4

EDIT : looks like a glitch from my setup : it freezes only if the watch if powered via the debugger. It's not the 1st time I notice such strange behavior that are most likely caused by interferences or bad contacts in my wiring and breadboard.

JF002 avatar Dec 26 '22 20:12 JF002