Indy icon indicating copy to clipboard operation
Indy copied to clipboard

Adding Lazarus Package file support to Indy 10.7

Open MWASoftware opened this issue 1 year ago • 2 comments

This pull requests removes the out-of-date "getIndy.sh" and replaces it with a set of lazarus packages in the new subdir "lazarus-fpc". This packages have the same structure as the Delphi packages and do not require any changes to the source tree to be used. Makefile.fpc files are also provided for use with fpcmake.

See README.lazarus-fpc for more information.

There are also some minor patches to the source files in order to ensure that they can be compiled with FPC.

MWASoftware avatar Jan 06 '25 13:01 MWASoftware

I have brought the Indy-10.7 branch in my repo up-to-date and tested. Note: I found an error in the merge changes from your upstream repo - a missing parameter in Lib/Core/IdDsnBaseCmpEdt.pas in a call to showaboutbox. I had to fix this to compile and test - hopefully added the correct param value.

If you do merge my changes in, I suggest you add "-s recursive -X renormalize" to git merge e.g.

git merge <my repo>/Indy-10.7 -s recursive -X renormalize

The reason for this is that I am working on Linux and some files have LF endings instead of CR/LF. See the .gitattributes file.

MWASoftware avatar Sep 20 '25 11:09 MWASoftware

Note: I found an error in the merge changes from your upstream repo - a missing parameter in Lib/Core/IdDsnBaseCmpEdt.pas in a call to showaboutbox. I had to fix this to compile and test - hopefully added the correct param value.

IdDsnBaseCmpEdt.pas is a dead unit, it hasn't been touched in 15 years, and nothing in Indy refers to it. It should be removed from the repo. The current About dialog is shown in IdCoreDsnRegister.pas, which calls TfrmAbout.ShowDlg(), which calls ShowAboutBox() with the correct 3 parameter values.

rlebeau avatar Sep 20 '25 17:09 rlebeau