Installer icon indicating copy to clipboard operation
Installer copied to clipboard

Nightly installer options don't work. Installing without custom options works normally.

Open auralius-dev opened this issue 5 years ago • 0 comments

Describe the bug Nightly installer buttons give errors when pressed.

To Reproduce Download nightly installer. Click a button.

Expected behavior The buttons to work.

Screenshots In additional context.

Additional Client Info
  • Operating System: Windows 10 64bit

Additional context

string

Cannot invoke "String.equals(Object)" because the return value of "io.github.lmpactDevelopment.installer.setting.InstallationConfig.getSettingValue(io.github.Impact Development.installer.setting. Setting)" is null is the error that is returned when choosing any dropdown button or the launcher directory button.

hash Cannot invoke "String.hashCode()" because "\<local1\>" is null is the error when pressing Install AFTER choosing a different option other than defaults.

Happens for exe and jar installers but only for the nightly installer.

If I don't select any options and just click install it works fine.

Logs from cmd,

Before clicking buttons
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Sending event category=installer action=display label=null cid=6df64d3a-52af-11eb-af69-7ea68c740367
Fetching releases from ImpactDevelopment/ImpactReleases
DOWNLOADING http://impactclient.net/releases.json
After clicking any dropdown or file select button
  {InstallationModeSetting=Official Launcher, MinecraftDirectorySetting=C:\Users\parke\AppData\Roaming\.minecraft, MinecraftVersionSetting=1.16.4, ImpactVersionSetting=io.github.ImpactDevelopment.installer.impact.ImpactVersionReleased@fa01c64, OptiFineToggleSetting=true}
java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "io.github.ImpactDevelopment.installer.setting.InstallationConfig.getSettingValue(io.github.ImpactDevelopment.installer.setting.Setting)" is null
        at io.github.ImpactDevelopment.installer.gui.pages.MainPage.buildOptiFineSetting(Unknown Source)
        at io.github.ImpactDevelopment.installer.gui.pages.MainPage.<init>(Unknown Source)
        at io.github.ImpactDevelopment.installer.gui.AppWindow.lambda$recreate$0(Unknown Source)
        at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:316)
        at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
        at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
        at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
        at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
        at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
        at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
        at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
        at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
        at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
        at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
After selecting a option and pressing install
Sending event category=installer action=install label=nightly-20210108-1.16.4 cid=6df64d3a-52af-11eb-af69-7ea68c740367
Sending event category=installer action=error label=nightly-20210108-1.16.4 cid=6df64d3a-52af-11eb-af69-7ea68c740367
java.lang.NullPointerException: Cannot invoke "String.hashCode()" because "<local1>" is null
        at io.github.ImpactDevelopment.installer.target.targets.Vanilla.getOptiFine(Unknown Source)
        at io.github.ImpactDevelopment.installer.target.targets.Vanilla.<init>(Unknown Source)
        at io.github.ImpactDevelopment.installer.setting.InstallationConfig.execute(Unknown Source)
        at io.github.ImpactDevelopment.installer.gui.pages.MainPage.lambda$new$0(Unknown Source)
        at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
        at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
        at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
        at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
        at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
        at java.desktop/java.awt.Component.processMouseEvent(Component.java:6614)
        at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3342)
        at java.desktop/java.awt.Component.processEvent(Component.java:6379)
        at java.desktop/java.awt.Container.processEvent(Container.java:2263)
        at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4990)
        at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
        at java.desktop/java.awt.Component.dispatchEvent(Component.java:4822)
        at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4919)
        at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4548)
        at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4489)
        at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
        at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2769)
        at java.desktop/java.awt.Component.dispatchEvent(Component.java:4822)
        at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
        at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
        at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
        at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
        at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
        at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
        at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
        at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
        at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
        at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
        at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
        at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
        at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
        at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

auralius-dev avatar Jan 09 '21 20:01 auralius-dev