ImpactDevelopment
Optifine related properties in impact json
We should support parsing a few optifine related stuff from impact jsons to allow an impact version to specify details about optifine compatibility.
We could possibly go about baritone in a similar way, depending on if we decide it makes more sense.
I envision an optionsl optifine object in the root of the json, which can either be a boolean or an object.
If a boolean it simply indicates whether optifine is supported at all. We should default to true if it is not present in the json.
If an object it can set verious properties sucn as boolean:supported, string:maxVersion, string:minVersion, string:tweakClass for overriding/setting the various settings.
Impact's gradle script would not need to set any of this, it would simply be supported by the installer in case we need to manually set any of this.
(This is also the kinda thing where it makes sense to be able to patch the json without re-releasing impact, but simply editing the existing release works, i guess)
IMO not really a priority.... we shouldnt bend over backwards to make special cases for a bug in 4.2...
I do agree that adding extra compatibility information is indeed an example where the json should be edited without rereleasing tho.
Sure, but it's better to have it in the json than have it in the installer. That way if there is a problem with a future release we just edit the json.
No issues if you don't want to work on this, but i think we should replace any hardcoded stuff with a json check at the very minimum.
Fair point. There isn't any hardcoded checks atm tho, it lets you put optifine on anything, whether itll work or not :wink: