igniteui-angular icon indicating copy to clipboard operation
igniteui-angular copied to clipboard

feat(dropdown): update indigo styles

Open SisIvanova opened this issue 1 year ago • 1 comments

Related to IgniteUI/igniteui-theming/issues/234

Additional information (check all that apply):

  • [ ] Bug fix
  • [ ] New functionality
  • [ ] Documentation
  • [ ] Demos
  • [ ] CI/CD

Checklist:

  • [x] All relevant tags have been applied to this PR
  • [ ] This PR includes unit tests covering all the new code (test guidelines)
  • [ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
  • [ ] This PR includes feature/README.MD updates for the feature docs
  • [ ] This PR includes general feature table updates in the root README.MD
  • [ ] This PR includes CHANGELOG.MD updates for newly added functionality
  • [ ] This PR contains breaking changes
  • [ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • [ ] This PR includes behavioral changes and the feature specification has been updated with them

SisIvanova avatar Apr 30 '24 14:04 SisIvanova

The first item margin-block is not 0, as in the WC PR

didimmova avatar May 07 '24 14:05 didimmova

  • paddings are 3px, but the border should be placed inside (in the kit, the space between the border and the active/hover background is 2px, not sure how you are going to implement it, but below you can see a reference from the kit) image image

AnjiManova avatar May 17 '24 11:05 AnjiManova

  • the applied elevation in Light is right (Elevation 3), but I don't think that the style of the elevation is defined the same as in the kit

  • the applied elevation in Dark is right (Elevation 2), but I'm not sure the style is the defined one in Figma

AnjiManova avatar May 17 '24 11:05 AnjiManova

The overline style is wrong. There is merged pr with the overline style, but still the change is not visible in this pr.

image

AnjiManova avatar May 17 '24 11:05 AnjiManova

The Focused & Hover state is logical and correct compared to the other states, and it should look like this IMO, but I'm not sure if it's by design ... @andiesm813 please confirm

Same for Active/Focused & Hover

AnjiManova avatar May 17 '24 12:05 AnjiManova

The text in Dark mode in Focused state should be white 80% not Grays.800

image

AnjiManova avatar May 17 '24 12:05 AnjiManova

@SisIvanova i couldnt run the samples from this branch. I got some errors:

image

andiesm813 avatar May 17 '24 23:05 andiesm813

  • the applied elevation in Light is right (Elevation 3), but I don't think that the style of the elevation is defined the same as in the kit
  • the applied elevation in Dark is right (Elevation 2), but I'm not sure the style is the defined one in Figma

I have to create a separate issue for all elevations. I was waiting to finish the last one i created so i could include all of them in the issue. All elevations are defined in the figma. They just havent been updated in the implemented elevations.

andiesm813 avatar May 17 '24 23:05 andiesm813

The Focused & Hover state is logical and correct compared to the other states, and it should look like this IMO, but I'm not sure if it's by design ... @andiesm813 please confirm

Same for Active/Focused & Hover

I will confirm when i can see it... i couldnt run the sample... @AnjiManova

andiesm813 avatar May 17 '24 23:05 andiesm813

  • after selecting an item and reopening the dropdown, the item stays focused image

Edit: as I mentioned to SisIvanova I'm not sure but this might be related to the keyboard navigation and the comment might not be relevant.

This comment needs more exploration (research), and based on the outcome, we could/should log a feature request in Angular.

AnjiManova avatar May 20 '24 12:05 AnjiManova

The overline style is wrong. There is merged pr with the overline style, but still the change is not visible in this pr.

image

The font-size is 11px and the line-height is 15px. I believe these are the correct sizes.

SisIvanova avatar May 27 '24 11:05 SisIvanova

  • the applied elevation in Light is right (Elevation 3), but I don't think that the style of the elevation is defined the same as in the kit
  • the applied elevation in Dark is right (Elevation 2), but I'm not sure the style is the defined one in Figma

All elevations will be updated in a separate PR

SisIvanova avatar May 27 '24 11:05 SisIvanova