feat(dropdown): update indigo styles
Related to IgniteUI/igniteui-theming/issues/234
Additional information (check all that apply):
- [ ] Bug fix
- [ ] New functionality
- [ ] Documentation
- [ ] Demos
- [ ] CI/CD
Checklist:
- [x] All relevant tags have been applied to this PR
- [ ] This PR includes unit tests covering all the new code (test guidelines)
- [ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
- [ ] This PR includes
feature/README.MDupdates for the feature docs - [ ] This PR includes general feature table updates in the root
README.MD - [ ] This PR includes
CHANGELOG.MDupdates for newly added functionality - [ ] This PR contains breaking changes
- [ ] This PR includes
ng updatemigrations for the breaking changes (migrations guidelines) - [ ] This PR includes behavioral changes and the feature specification has been updated with them
The first item margin-block is not 0, as in the WC PR
- paddings are 3px, but the border should be placed inside (in the kit, the space between the border and the active/hover background is 2px, not sure how you are going to implement it, but below you can see a reference from the kit)
-
the applied elevation in Light is right (Elevation 3), but I don't think that the style of the elevation is defined the same as in the kit
-
the applied elevation in Dark is right (Elevation 2), but I'm not sure the style is the defined one in Figma
The overline style is wrong. There is merged pr with the overline style, but still the change is not visible in this pr.
The Focused & Hover state is logical and correct compared to the other states, and it should look like this IMO, but I'm not sure if it's by design ... @andiesm813 please confirm
Same for Active/Focused & Hover
The text in Dark mode in Focused state should be white 80% not Grays.800
@SisIvanova i couldnt run the samples from this branch. I got some errors:
- the applied elevation in Light is right (Elevation 3), but I don't think that the style of the elevation is defined the same as in the kit
- the applied elevation in Dark is right (Elevation 2), but I'm not sure the style is the defined one in Figma
I have to create a separate issue for all elevations. I was waiting to finish the last one i created so i could include all of them in the issue. All elevations are defined in the figma. They just havent been updated in the implemented elevations.
The Focused & Hover state is logical and correct compared to the other states, and it should look like this IMO, but I'm not sure if it's by design ... @andiesm813 please confirm
Same for Active/Focused & Hover
I will confirm when i can see it... i couldnt run the sample... @AnjiManova
- after selecting an item and reopening the dropdown, the item stays focused
Edit: as I mentioned to SisIvanova I'm not sure but this might be related to the keyboard navigation and the comment might not be relevant.
This comment needs more exploration (research), and based on the outcome, we could/should log a feature request in Angular.
The overline style is wrong. There is merged pr with the overline style, but still the change is not visible in this pr.
![]()
The font-size is 11px and the line-height is 15px. I believe these are the correct sizes.
- the applied elevation in Light is right (Elevation 3), but I don't think that the style of the elevation is defined the same as in the kit
- the applied elevation in Dark is right (Elevation 2), but I'm not sure the style is the defined one in Figma
All elevations will be updated in a separate PR