igniteui-angular icon indicating copy to clipboard operation
igniteui-angular copied to clipboard

feat(checkbox): complete checkbox refinements

Open didimmova opened this issue 1 year ago • 1 comments

Closes #14107

Additional information (check all that apply):

  • [ ] Bug fix
  • [ ] New functionality
  • [ ] Documentation
  • [ ] Demos
  • [ ] CI/CD

Checklist:

  • [ ] All relevant tags have been applied to this PR
  • [ ] This PR includes unit tests covering all the new code (test guidelines)
  • [ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
  • [ ] This PR includes feature/README.MD updates for the feature docs
  • [ ] This PR includes general feature table updates in the root README.MD
  • [ ] This PR includes CHANGELOG.MD updates for newly added functionality
  • [ ] This PR contains breaking changes
  • [ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • [ ] This PR includes behavioral changes and the feature specification has been updated with them

didimmova avatar Apr 24 '24 12:04 didimmova

Bootstrap Theme:

  • Wrong font-style
  • Check the empty invalid checkbox on focus both light and dark variant (the border color is wrong)
  • The tick mark looks bigger than the UI kit but I will leave this to the design team

SisIvanova avatar May 08 '24 07:05 SisIvanova

All themes

  • Tick isn't properly aligned to the center of the checkbox (both for checked and indeterminate state)

Bootstrap

  • Tick SVG needs to be updated, in order to match the most recent changes in the UI kit (it has been updated, in order to match the official Bootstrap component)*
  • Tick in all themes (both for checked and indeterminate state) isn't properly aligned to the center of the checkbox
  • Invalid unchecked state: when in hover and focused state, the border color isn't linked to the proper variable (--error-color-hover)

*EDIT: Since the new SVG will be implemented later on, the comment here should be considered as irrelevant

imincheva avatar May 13 '24 14:05 imincheva

Fluent

  • Invalid unchecked: the tick color on hover and focused & hover state should be error.500

imincheva avatar May 14 '24 07:05 imincheva

Material

The Active state of the unchecked checkbox (ripple) in light and dark should be changed. Let's try with the --empty-color and the current opacity.

Everything else looks good.

AnjiManova avatar May 14 '24 08:05 AnjiManova

@didimmova make sure that this is working correctly in all browsers.

@if $variant == 'material' {
    inset-inline-start: -.5px;
}

half-pixel values may have rendering problems in different browsers.

desig9stein avatar May 16 '24 06:05 desig9stein