igniteui-angular icon indicating copy to clipboard operation
igniteui-angular copied to clipboard

Fix some errors in the grid samples

Open jackofdiamond5 opened this issue 2 years ago • 0 comments

This PR fixes some errors that were thrown when opening some of the grids samples. We had services that were not provided anywhere and Angular was complaining because of that. Additionally, the grid row edit sample threw the expression changed exception and finally in the grid-base sample we were not using the new API of the IChangeCheckboxEventArgs so the sample did not load at all.

Not for testing - run a browser with CORS disabled otherwise there will be errors in the console since some samples do requests. No grid sample should be throwing any errors when routed to.

Additional information (check all that apply):

  • [x] Bug fix
  • [ ] New functionality
  • [ ] Documentation
  • [x] Demos
  • [ ] CI/CD

Checklist:

  • [ ] All relevant tags have been applied to this PR
  • [ ] This PR includes unit tests covering all the new code (test guidelines)
  • [ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
  • [ ] This PR includes feature/README.MD updates for the feature docs
  • [ ] This PR includes general feature table updates in the root README.MD
  • [ ] This PR includes CHANGELOG.MD updates for newly added functionality
  • [ ] This PR contains breaking changes
  • [ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • [ ] This PR includes behavioral changes and the feature specification has been updated with them

jackofdiamond5 avatar Jan 26 '24 15:01 jackofdiamond5