igniteui-angular icon indicating copy to clipboard operation
igniteui-angular copied to clipboard

Improve package tree-shaking

Open kdinev opened this issue 2 years ago • 6 comments

Is your feature request related to a problem? Please describe.

Currently there's parts of the packages that are not tree-shaken optimally, like:

  • [x] i18n resouces (igniteui-angular-i18n) #13411
  • [x] trial-watermark #13442
  • [x] i18n built-in EN resources #13493
  • [x] animations #13494
  • [x] text highlight directive #13915
  • [x] utils
  • [x] #13677
  • [x] grid #13412
  • [x] grid paginator #13896
  • [x] grid toolbar #13897
  • [x] grid action strip #13900

Describe the solution you'd like

The code for the parts mentioned above should be tree-shaken when not used.

kdinev avatar Oct 18 '23 08:10 kdinev

@damyanpetev @igdmdimitrov About the text-highlight directive/service. Who should be the right person to own the refactoring?

kdinev avatar Oct 19 '23 07:10 kdinev

@damyanpetev @igdmdimitrov I'm reopening the issue because of the text-highlight. I still need an answer on who the owner of this should be (an issue needs to be created). Utils can also benefit from further refactor.

kdinev avatar Oct 30 '23 07:10 kdinev

@kdinev Well I have to look at the small utils things that weren't tree shaking after the updates anyway, so I might as well have a look at the highlight directive too

damyanpetev avatar Oct 30 '23 12:10 damyanpetev

@damyanpetev I suggest separate issues be logged for each!

kdinev avatar Oct 30 '23 12:10 kdinev

There has been no recent activity and this issue has been marked inactive.

github-actions[bot] avatar Jan 28 '24 00:01 github-actions[bot]

@damyanpetev Could you update the checklist with the ideas you had about refactoring the grid paginator usage for better tree-shaking?

kdinev avatar Jan 30 '24 08:01 kdinev