ryot icon indicating copy to clipboard operation
ryot copied to clipboard

PWA Icon File

Open Jacob-Tate opened this issue 1 year ago • 4 comments

After a decent amount of research it appears the following conditions determine the PWA icon.

  • Browser
  • OS
  • Version of the OS
  • Launcher
  • Dark Mode / Lite Mode
  • User Preferences

For example. OS: Android 14 Launcher: One UI 6.1 Browser: Firefox

This combination respects the manifest files "background_color": "#fd7e14" line and makes the pwa icon look like this regardless of darkmode settings. image

This occurs by pulling a copy of icon-256x256.png

Whereas:

OS: Android 14 Launcher: One UI 6.1 Browser: Chrome Dark Mode: Yes

image

This occurs by pulling android-chrome-{insert size here} this does allow us to use an SVG to handle a darkmode switch but it can be a bit tricky to get that right.

Another example: OS: Android 14 Launcher: One UI 6.1 Browser: Builtin Samsung Browser Dark Mode: Yes

image

This one is different from the others in that it completely ignores the android manifest files and will instead search for apple-touch-icon.png and places it on a white background. This is a problem because apple places these images on a black background so one of them will be broken.

Proposal

After checking what some other projects have done to address this problem most of them like mealie appear to change the logo to not use black or white in the logo rather using another color since it will work regardless of the OS and browser. Maybe we should consider switching to another color like the background_color as the logo color.

Like so: ryot-icon

I can upload the illustrator file later for you incase you ever need it.

Jacob-Tate avatar Aug 09 '24 23:08 Jacob-Tate

I wanted thoughts on if we should do this before making a PR. Also this is for the PWA / favicon.

Jacob-Tate avatar Aug 09 '24 23:08 Jacob-Tate

Do you have any suggestions on the color itself?

IgnisDa avatar Aug 10 '24 00:08 IgnisDa

Im not quite sure which one to pick here are some samples. Ignore the red dot in some of these they are screenshots from illustrator.

Color Code Black White
Cranberry b21f24 image image
Dark Red 6c0000 image image
Baby Blue 00b7f1 image image
Dark Fusia b11a51 image image
Light Green 71c063 image image
Yellow efea50 image image
Dark Purple 434380 image image

Jacob-Tate avatar Aug 10 '24 04:08 Jacob-Tate

Could you DM this to me on Discord? I can make a post tagging everyone on the discord server.

IgnisDa avatar Aug 10 '24 04:08 IgnisDa

I think we can put a pin on this for now. I do not plan to change icons right now. Thanks for your work on this!

IgnisDa avatar Aug 18 '24 05:08 IgnisDa