IdentityServer3.WsFederation icon indicating copy to clipboard operation
IdentityServer3.WsFederation copied to clipboard

Feature/fix exceptions on invalid parameters

Open pi3k14 opened this issue 9 years ago • 4 comments

Cleaned up some fault handling which previously resulted in thrown exceptions

pi3k14 avatar Sep 22 '16 08:09 pi3k14

Did you check the ws-fed spec what the exact status codes should be?

leastprivilege avatar Sep 26 '16 08:09 leastprivilege

Haven't changed/added any status codes (or validated their validity), just ensured that they didn't get swallowed in an Internal Server error.

pi3k14 avatar Sep 27 '16 11:09 pi3k14

@scottbrady91 could you have a look please?

leastprivilege avatar Sep 27 '16 11:09 leastprivilege

If the try catch block is the only change, I'm happy for this to be merged once the exception message is removed from the BadRequest

scottbrady91 avatar Oct 03 '16 15:10 scottbrady91