IdentityServer3.AccessTokenValidation icon indicating copy to clipboard operation
IdentityServer3.AccessTokenValidation copied to clipboard

2.15 causes deadlocks/hangs under heavy load

Open ErikEJ opened this issue 8 years ago • 10 comments

It looks like this change causes thread deadlocks/hangs under heavy load (many requests (several 100s per second) running under ASP.NET) - why was the quick exit removed? https://github.com/IdentityServer/IdentityServer3.AccessTokenValidation/commit/dec7f5c14784ddcaeb3c99aaf3cced7ddf22eed1#diff-5b2c5cc8b17ae721dd148a69c90508e6L136

WebAPI 2 under ASP.NET 4.6 in Azure App Service

ErikEJ avatar Sep 08 '17 06:09 ErikEJ

Would this help?

https://github.com/IdentityServer/IdentityServer3.AccessTokenValidation/pull/155

leastprivilege avatar Sep 08 '17 07:09 leastprivilege

Sure, as it rolls back the behaviour to 2.14 implementation (which we had to roll back to)

ErikEJ avatar Sep 08 '17 07:09 ErikEJ

@NicolaiPetri !

ErikEJ avatar Sep 08 '17 07:09 ErikEJ

We did an update that's supposed to deal with the deadlock in Microsoft's config loader. Please test again the myget version and let us know. https://www.myget.org/gallery/identity

Thanks

brockallen avatar Sep 08 '17 15:09 brockallen

Is this recommended over / better performance wise than 2.14, that we have reverted to in production?

ErikEJ avatar Sep 08 '17 15:09 ErikEJ

We hope this fixes the problem. But you need to test it.

leastprivilege avatar Sep 08 '17 18:09 leastprivilege

Have you done any testing?

ErikEJ avatar Sep 08 '17 18:09 ErikEJ

No - but we think this is the root cause.

leastprivilege avatar Sep 08 '17 19:09 leastprivilege

I would be great if you were able to verify that - I will investigate possible test procedures

ErikEJ avatar Sep 08 '17 19:09 ErikEJ

#155 seems like the correct fix here.

strtdusty avatar Oct 20 '17 18:10 strtdusty